Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoomDelay, zoomFactor ordering #1

Closed
quatrano opened this issue Dec 4, 2014 · 1 comment
Closed

zoomDelay, zoomFactor ordering #1

quatrano opened this issue Dec 4, 2014 · 1 comment

Comments

@quatrano
Copy link
Contributor

quatrano commented Dec 4, 2014

Currently, on "mousedown" on a zoom button, there is a zoomDelay, and then the zoomFactor is applied. If the delay is long enough, a quick click can be swallowed, and the zoomFactor will never be applied. Furthermore, this feels like lag to the user.

The zoomFactor should be applied immediately, then the zoomDelay, zoomFactor, ... etc. (The important difference being that the zoomFactor is applied once before the delay.)

Here's the function of interest:
https://github.com/cytoscape/cytoscape.js-panzoom/blob/master/cytoscape.js-panzoom.js#L384

@maxkfranz
Copy link
Member

I suppose I'll close this on account of your pull request. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants