Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fit options #14

Closed
ugurdogrusoz opened this issue Jun 1, 2016 · 4 comments
Closed

Additional fit options #14

ugurdogrusoz opened this issue Jun 1, 2016 · 4 comments
Assignees

Comments

@ugurdogrusoz
Copy link

We (@metincansiper) added additional parameters for fit in window functionality of this extension:

  • whether or not fit should be animated (see how animated fit in window works here: http://cs.bilkent.edu.tr/~ivis/SBGNViz.js_editor/sample-app)
  • a selector which decides on what nodes to perform the fit (we needed this for making sure hidden - currently not visible - graph objects are not considered during the operation)

@maxkfranz Let us know if you'd like either of these to be included in this extension.

@maxkfranz
Copy link
Member

@ugurdogrusoz Great, I've added you to npm so you guys can push a 2.4.0 release with the new features: https://www.npmjs.com/package/cytoscape-panzoom

Thanks

@maxkfranz maxkfranz removed their assignment Jun 1, 2016
@ugurdogrusoz
Copy link
Author

@metincansiper Maybe we can add animated zoom as well, and use this extension out of box from that point on.

@ugurdogrusoz
Copy link
Author

Let's drop animated zoom since it's problematic due to multiple calls to the associated function when zoom slider is used.

@metincansiper
Copy link
Contributor

@ugurdogrusoz @maxkfranz
I drop animated zoom and published 2.4.0 with other changes mentioned in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants