Remove unused var, replace temps and block.call with yield

[ridiculous]

No description provided.

[dirk]

To actually get a memory/performance benefit from this change you also need to remove the &block in the definition of this method.

[ridiculous]

we won't get the memory savings because we need block on line 26. But we should see a slight increase in speed.

[dirk]

So @ridiculous has a good set of changes here.

@cyu: Could you please take some time to review this?

[cyu]

I still need a block to check the arity

[ridiculous]

Should I revert the block.call part and make this only about removing the vars?

[dirk]

@cyu: Investigating the arity stuff to see if we can get rid of &block while still keeping the same functionality.

[dirk]

@ridiculous: So I investigated this, and Proc.new() does contain arity information about the passed block. The following should therefore work for the code that @cyu was concerned about:

      if block_given?
        block = Proc.new
        if block.arity == 1
          block.call self
        else
          instance_eval(&block)
        end
      end

[cyu]

@dirk the block_given? == false use case is so rare that I don't think there's a lot to gain from this optimization. And I can't imagine there being a large advantage from using &block verses Proc.new in terms of performance.

Having said that, the block.call self execution path is there to support an older configuration method that really isn't documented anymore - we can probably remove that (obsoleting the need for the arity call) which will allow us to use Proc.new instead of &block. I would then incorporate this as a major version change.

[ridiculous]

Is there a change that is being requested on this PR?