CORE-1120: completed implementation of new notifications service. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it to the route handlers
…ters to the /v1/messages endpoint
…essages` endpoint
…the `/v2/messages` endpoint
…essages` endpoint
…d ID validation to the `/v2/messages/{id}` endpoint
…d a little refactoring
slr71
force-pushed
the
v1-api
branch
2 times, most recently
from
5a9f95e
to
b843caf
Compare
slr71
commented
Sep 18, 2020
ianmcorvidae
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Things look pretty good to me. I have a few comments, mostly ideas on concision. I was pretty confused by one section of code that I'm hoping you can help clarify. I also still need to learn how labstack/echo works better, so I may do another pass on this, but don't wait on me to do that or anything, heh.
…correct placeholder format
… fields in the response body for the /v2/messages endpoint
|
I'm going to merge this PR now. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.