Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /communities endpoints for App Community CRUD and admin management #71

Open
psarando opened this issue Oct 10, 2018 · 2 comments
Open

Add /communities endpoints for App Community CRUD and admin management #71

psarando opened this issue Oct 10, 2018 · 2 comments
Assignees
@psarando

Comments

@psarando
Copy link
Member

psarando commented Oct 10, 2018 •
edited

These endpoints will mostly be the same as the /teams endpoints, but will operate on a new communities Grouper folder, and communities will not require members apart from admins.

The list of endpoints to be added:

  • GET /communities
  • POST /communities
  • GET /communities/:name
  • PATCH /communities/:name
  • DELETE /communities/:name
  • GET /communities/:name/admins
  • POST /communities/:name/admins
  • POST /communities/:name/admins/deleter
  • GET /admin/communities
  • POST /admin/communities
  • GET /admin/communities/:name
  • PATCH /admin/communities/:name
  • DELETE /admin/communities/:name
  • GET /admin/communities/:name/admins
  • POST /admin/communities/:name/admins
  • POST /admin/communities/:name/admins/deleter
@psarando psarando self-assigned this Oct 10, 2018
@ianmcorvidae
Copy link
Member

Gonna be the one to ask the annoying procedural question: should we make a small (go, probably) microservice that terrain delegates to for this group of endpoints?

@psarando
Copy link
Member Author

should we make a small (go, probably) microservice that terrain delegates to for this group of endpoints?

Not at this time. All the current /teams endpoints are already implemented in terrain, and these endpoints are just going to reuse those existing functions, but with minor tweaks, such as Grouper folder name changes.

psarando added a commit to psarando/cyverse-de-terrain that referenced this issue Oct 11, 2018
@psarando
cyverse-de#71 Add /communities endpoints for App Community management.
6bf0c6e 
Mainly modifies existing teams functions for creating groups as either
iplant:de:<env>:teams:<user>:<name> or
iplant:de:<env>:communities:<user>:<name>

New Communities will be publicly viewable by default,
with the creator as the initial admin.

Also added a `payload.action` to each Team notification,
since the UI seems to be looking for an `added_to_team` action,
but is currently checking the `email_template` instead.
This was referenced Oct 11, 2018
Merged
Closed
psarando added a commit to psarando/cyverse-de-terrain that referenced this issue Oct 17, 2018
@psarando
cyverse-de#71 Update App Community names created by POST /communities.
6cb4f64 
Updated terrain.clients.iplant-groups/add-community to create community
groups with names formatted like
iplant:de:<env>:communities:<name>
(keeping communities out of the requesting user's namespace).
psarando added a commit to psarando/cyverse-de-terrain that referenced this issue Oct 18, 2018
@psarando
cyverse-de#71 Fix for renaming App Communities.
3d781a4
@psarando psarando mentioned this issue Oct 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psarando psarando

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianmcorvidae @psarando