This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
Fix image scripts not being included in user deploy #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianpistorius
approved these changes
Mar 5, 2018
cdosborn
force-pushed
the
deploy-image-scripts
branch
from
40ea436
to
6d40789
Compare
|
My original patch was so small it seemed like it would just work (and I did test it locally). It turned out not to work. Because you cannot filter over a queryset that has been evaluated. (you can, but you get nonsense results). Anywho to the power of writing tests for even the smallest changes. |
In this commit acb6729, we removed the task which ran image scripts against an instance. There is a lot confusing terminology that needs to be cleaned up.
This test will start failing when it has built up results in the redis cache. Need to revisit it, but travis doesn't catch it because it starts with a clean cache.
cdosborn
force-pushed
the
deploy-image-scripts
branch
from
6d40789
to
74a08ac
Compare
This test case broke when the instance_factory began returning a project. This change makes the test only compare values it is actively trying to test, namely the assignment of an allocation source.
This test case broke when the instance_factory began returning a project. This change makes the test only compare values it is actively trying to test, namely instance name.
cdosborn
force-pushed
the
deploy-image-scripts
branch
from
74a08ac
to
46666ed
Compare
julianpistorius
approved these changes
Mar 6, 2018
| from api.tests.factories import BootScriptRawTextFactory, InstanceFactory, UserFactory | ||
|
|
||
|
|
||
| class UserDeployTests(TestCase): |
| @@ -172,6 +172,7 @@ def test_user_sees_no_statistics(self): | |||
| response = client.get(url) | |||
| self.assertEquals(response.status_code, 404) | |||
|
|
|||
| @skip("Test is non deterministic and yields different results based on its redis cache") | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem:
Image scripts are never deployed to an instance
Solution:
Deploy image scripts alongside instance scripts
In this commit acb6729, we removed the task which ran image scripts against an instance.
Checklist before merging Pull Requests
[ ] Documentation created/updated at Example link to documentation to give context to the feature[ ] If creating/modifying DB models which will contain secrets or sensitive information, PR to clank updating sanitation queries inroles/sanitary-sql-access/templates/sanitize-dump.sh.j2[ ] New variables supported in Clank[ ] New variables committed to secrets repos