Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

Commit

Permalink
Include d3, bootstrap-sass master
Browse files Browse the repository at this point in the history 
bootstrap-sass is pointing to github while we are awaiting a fix to a
sass bug (twbs/bootstrap-sass#919)
  • Loading branch information
@cdosborn
cdosborn committed Aug 12, 2015
1 parent 9b71d60 commit a8144d2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion package.json
View file
Expand Up @@ -23,8 +23,9 @@
"dependencies": {
"babel-runtime": "^5.8.12",
"backbone": "^1.2.1",
"bootstrap-sass": "^3.3.5",
"bootstrap-sass": "https://github.com/twbs/bootstrap-sass.git",
"crypto-js": "^3.1.5",
"d3": "^3.5.6",
"highcharts-commonjs": "^4.1.7-1",
"jquery": "^2.1.3",
"moment": "^2.10.6",
Expand Down

2 comments on commit a8144d2

@steve-gregory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the bug manifest itself, how might other users find out if they are affected?

I ask because I recently had trouble with the Troposphere build that may/may not be related to this?

@cdosborn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug doesn't affect builds, it just results in a render artifact. We were relying on boostrap master, which had a fix. Now they have a stable release including the bug fix, which is 3.3.6.

Please sign in to comment.