Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Hosts who don't support SHA2, GCM or PKCS5.pbkdf2_hmac #3

Merged
merged 1 commit into from
Mar 1, 2013
Merged

Fix for Hosts who don't support SHA2, GCM or PKCS5.pbkdf2_hmac #3

merged 1 commit into from
Mar 1, 2013

Conversation

Asmod4n
Copy link
Contributor

@Asmod4n Asmod4n commented Mar 1, 2013

Some Hosts have Compiled Ruby against older Versions of OpenSSL, rendering SHA2, GCM and OpenSSL::PKCS5.pbkdf2_hmac useless.

This fixes it and also incorporates a safer Password checking routine, as seen on http://www.ruby-doc.org/stdlib-2.0/libdoc/openssl/rdoc/OpenSSL/PKCS5.html

cyx added a commit that referenced this pull request Mar 1, 2013
Fix for Hosts who don't support SHA2, GCM or PKCS5.pbkdf2_hmac
@cyx cyx merged commit 0185145 into cyx:master Mar 1, 2013
@cyx
Copy link
Owner

cyx commented Mar 2, 2013

Hmm I didn't check hard enough. I might have to revert the change given the backward incompatible nature of the change. Hope you don't mind.

@Asmod4n
Copy link
Contributor Author

Asmod4n commented Mar 2, 2013

@cyx It was quite late so i forgot that, but i can't test it myself because PBKDF2 always returns nil under ruby 2.0 on my Host.

There is a updated Version of pbkdf2-ruby which fixes it, but he doesn't release the Fix.
https://github.com/emerose/pbkdf2-ruby/blob/master/lib/pbkdf2.rb

@cyx
Copy link
Owner

cyx commented Mar 2, 2013

Ok got it. I'll take a look at PBKDF2 ruby 2.0 problems.

Asmod4n wrote:

It was quite late so i forgot that, but i can't test it myself because
PBKDF2 always returns nil under ruby 2.0 on my Host.


Reply to this email directly or view it on GitHub
#3 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants