Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert NDTiff with non-HCS position labels #169

Closed
ziw-liu opened this issue Aug 7, 2023 · 0 comments · Fixed by #171
Closed

Convert NDTiff with non-HCS position labels #169

ziw-liu opened this issue Aug 7, 2023 · 0 comments · Fixed by #171
Assignees
Labels
enhancement New feature or request μManager Micro-Manager files and metadata

Comments

@ziw-liu
Copy link
Collaborator

ziw-liu commented Aug 7, 2023

          > We should test that these new datasets are correctly converted to zarr, whether they carry HCS or 'Pos0'... position labels

I am guessing that this segment will need to be modified to provide string indices for the position and channel axes, rather than integers. These should be obtained from NDTiffReader._axes, such that you call dataset.as_array(position='Pos1',...) rather than dataset.as_array(position=1,...)

iohub/iohub/convert.py

Lines 254 to 263 in 1ae2737

# create array of coordinate tuples with innermost dimension
# being the first dim acquired
self.coords = [
(dim3, dim2, dim1, dim0)
for dim3 in range(dims[3])
for dim2 in range(dims[2])
for dim1 in range(dims[1])
for dim0 in range(dims[0])
]

Do you mean that the converted OME-Zarr will have path names that reflect non-HCS MM stage position labels? Currently we put each position in a separate well in a single row, will this behavior be preserved, thus producing FOV paths 0/Pos000/0, 0/Pos001/0 etc?

Originally posted by @ziw-liu in #166 (comment)

@ziw-liu ziw-liu added enhancement New feature or request μManager Micro-Manager files and metadata labels Aug 8, 2023
@ziw-liu ziw-liu self-assigned this Aug 8, 2023
@ziw-liu ziw-liu linked a pull request Aug 14, 2023 that will close this issue
@ziw-liu ziw-liu changed the title Convert NDTiff with HCS position labels Convert NDTiff with non-HCS position labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request μManager Micro-Manager files and metadata
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant