Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iohub convert writing to both highest resolution scale metadata and highest level #174

Closed
edyoshikun opened this issue Aug 15, 2023 · 0 comments · Fixed by #175
Closed

Comments

@edyoshikun
Copy link
Contributor

edyoshikun commented Aug 15, 2023

From our discussion on mantis and the metadata scaling @talonchandler @ziw-liu , I have found that iohub converts and adds the scale metadata to both the top of the 'pyramid' and the highest resolution level.

Should the normal behavior be to write into the datasets dictionary rather than the higher level coordinateTransformation as shown below or should the the highest level (top of pyramid) always be "scale":[1,1,1,1,1]" Since the ngff.Position.scale, always looks for the highest resolution, then shouldn't we leave the top level of the pyramid to be untouched (?)

            "coordinateTransformations": [
                {
                    "scale": [
                        1.0,
                        1.0,
                        0.143,
                        0.1494,
                        0.1494
                    ],
                    "type": "scale"
                }
            ],
            "datasets": [
                {
                    "coordinateTransformations": [
                        {
                            "scale": [
                                1.0,
                                1.0,
                                0.143,
                                0.1494,
                                0.1494
                            ],
                            "type": "scale"
                        }
                    ],

/hpc/projects/comp.micro/mantis/2023_08_09_HEK_PCNA_H2B/0-zarr/pcna_rac1_virtual_staining_1/pcna_rac1_virtual_staining_labelfree_1.zarr/0/0/0/.zattrs

@ziw-liu ziw-liu linked a pull request Aug 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant