Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tifffile version breaks the OME-TIFF reader #94

Closed
ziw-liu opened this issue Mar 17, 2023 · 1 comment · Fixed by #95
Closed

New tifffile version breaks the OME-TIFF reader #94

ziw-liu opened this issue Mar 17, 2023 · 1 comment · Fixed by #95
Assignees
Labels
bug Something isn't working CI Continuous integration maintenance Maintenance work

Comments

@ziw-liu
Copy link
Collaborator

ziw-liu commented Mar 17, 2023

          > Tifffile v2023.3.15 includes a new parser for MMStack series and reverts the MicroManager specific optimizations for OME series. Positions are now returned as a dimension in the series rather than as separate series. The dimension order is parsed from the MM metadata and might differ from OME. I only have a limited number of test files, many of which are corrupted in one way or another. Hope it works for you.

@cgohlke Thanks for letting us know! I have yet to change the related code here, so I have to pin the tifffile version on the main branch for now to avoid this breaking change.

Originally posted by @ziw-liu in #66 (comment)

@ziw-liu ziw-liu self-assigned this Mar 17, 2023
@ziw-liu ziw-liu added bug Something isn't working maintenance Maintenance work CI Continuous integration labels Mar 17, 2023
@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Mar 17, 2023

A temporary pin of the dependency is necessary before the reader gets fixed so that users can still install and use iohub from the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous integration maintenance Maintenance work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant