Add Image Optimisation strategy #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't require the the image optimizer package, suggest it instead. It should not be a hard dependency of this package!
Cleanup: removed todo comment, adjusted code style, renamed for abbreviation
Minor docblock and newline tweak
Minor newline tweak
Documentation tweak for ImageOptimizationStrategy
|
Had a chance to check this, and it's looking good. If you can find the time to add test(s) for this strategy, that would be great! |
|
Thanks Conrad. Sure thing :)
Oh and as for the method naming, the arrGet method was consistent with the
other Image Support classes, I'm not sure if you want to update them there
to reflect things as well.
…On Fri., 24 Aug. 2018, 14:57 Conrad Carpenter, ***@***.***> wrote:
Had a chance to check this, and it's looking good. If you can find the
time to add test(s) for this strategy, that would be great!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFLO7s3QcvXLrAMsoOXjn1AmzzJLoJpnks5uT_gkgaJpZM4WH5I9>
.
|
|
My bad, then -- looks like I will need to update those too. Good catch :] |
Renames ImageOptimizeStrategy to ImageOptimizationStrategy to be consistent.
|
Sorry for leaving you hanging on this one. I've just followed the same testing style as the others, it doesn't exactly assert that the image has been optimised, but it asserts that the class does perform the function on the same file. |
|
Any chance of getting this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: czim/laravel-paperclip#24 (comment)
This uses https://github.com/spatie/image-optimizer/ behind the scenes to take care of image optimisation.
Right now it's just using Spatie's defaults, but it could be extended to accept optimisation options as well.