This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
Hotfix/table prefix once #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2019 08:13
Encountered “cms_cms_cms_<table>” where “cms_” is the prefix.
|
Interesting detail: the actual code branch that does prefix the table name never runs in the tests, decreasing coverage: https://coveralls.io/builds/25599252/source?filename=src/Sentinel/CmsTablePrefixed.php#L21. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents table names from being prefixed more than once
Encountered errors due to table names with 2 or 3 prefixes, like
cms_cms_cms_<table>wherecms_is the prefix. Errors occured on authenticating CMS users after login, and creating users withcms:user:create. The error might also occur in other model-touching code.