Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

Php 7.2 support: Cast to array when counting #6

Closed
wants to merge 1 commit into from
Closed

Php 7.2 support: Cast to array when counting #6

wants to merge 1 commit into from

Conversation

daniel-de-wit
Copy link
Contributor

Fixes #5

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.931% when pulling 22b3d72 on daniel-de-wit:patch-2 into 32dc984 on czim:master.

@czim
Copy link
Owner

czim commented Nov 2, 2018

Thanks for the suggestion! I've found a slightly cleaner way to prevent issues with uncountable values in PHP 7.2 -- the problem was with getMeta() in the modeltransformer.

@czim czim closed this Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daniel-de-wit @coveralls @czim