Fix CefListValue "int index" params (#461).

cztomczak · Jan 14, 2020 · fb2d94c · fb2d94c
1 parent d9587bc
commit fb2d94c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 21 deletions.
diff --git a/src/extern/cef/cef_values.pxd b/src/extern/cef/cef_values.pxd
@@ -72,20 +72,20 @@ cdef extern from "include/cef_values.h":
         cpp_bool SetSize(size_t size)
         size_t GetSize()
         cpp_bool Clear()
-        cpp_bool Remove(int index)
-        cef_value_type_t GetType(int index)
-        cpp_bool GetBool(int index)
-        int GetInt(int index)
-        double GetDouble(int index)
-        CefString GetString(int index)
-        CefRefPtr[CefBinaryValue] GetBinary(int index)
-        CefRefPtr[CefDictionaryValue] GetDictionary(int index)
-        CefRefPtr[CefListValue] GetList(int index)
-        cpp_bool SetNull(int index)
-        cpp_bool SetBool(int index, cpp_bool value)
-        cpp_bool SetInt(int index, int value)
-        cpp_bool SetDouble(int index, double value)
-        cpp_bool SetString(int index, const CefString& value)
-        cpp_bool SetBinary(int index, CefRefPtr[CefBinaryValue] value)
-        cpp_bool SetDictionary(int index, CefRefPtr[CefDictionaryValue] value)
-        cpp_bool SetList(int index, CefRefPtr[CefListValue] value)
+        cpp_bool Remove(size_t index)
+        cef_value_type_t GetType(size_t index)
+        cpp_bool GetBool(size_t index)
+        int GetInt(size_t index)
+        double GetDouble(size_t index)
+        CefString GetString(size_t index)
+        CefRefPtr[CefBinaryValue] GetBinary(size_t index)
+        CefRefPtr[CefDictionaryValue] GetDictionary(size_t index)
+        CefRefPtr[CefListValue] GetList(size_t index)
+        cpp_bool SetNull(size_t index)
+        cpp_bool SetBool(size_t index, cpp_bool value)
+        cpp_bool SetInt(size_t index, int value)
+        cpp_bool SetDouble(size_t index, double value)
+        cpp_bool SetString(size_t index, const CefString& value)
+        cpp_bool SetBinary(size_t index, CefRefPtr[CefBinaryValue] value)
+        cpp_bool SetDictionary(size_t index, CefRefPtr[CefDictionaryValue] value)
+        cpp_bool SetList(size_t index, CefRefPtr[CefListValue] value)
diff --git a/src/process_message_utils.pyx b/src/process_message_utils.pyx
@@ -92,8 +92,8 @@ cdef list CefListValueToPyList(
     if nestingLevel > 8:
         raise Exception("CefListValueToPyList(): max nesting level (8)"
                 " exceeded")
-    cdef int index
-    cdef int size = int(cefListValue.get().GetSize())
+    cdef size_t index
+    cdef size_t size = cefListValue.get().GetSize()
     cdef cef_types.cef_value_type_t valueType
     cdef list ret = []
     cdef CefRefPtr[CefBinaryValue] binaryValue
@@ -230,7 +230,7 @@ cdef CefRefPtr[CefListValue] PyListToCefListValue(
     cdef type valueType
     cdef CefRefPtr[CefListValue] ret = CefListValue_Create()
     cdef CefRefPtr[CefBinaryValue] binaryValue
-    cdef int index
+    cdef size_t index
     for index_size_t, value in enumerate(pyList):
         index = int(index_size_t)
         valueType = type(value)
@@ -289,7 +289,7 @@ cdef void PyListToExistingCefListValue(
                 " exceeded")
     cdef type valueType
     cdef CefRefPtr[CefListValue] newCefListValue
-    cdef int index
+    cdef size_t index
     for index_size_t, value in enumerate(pyList):
         index = int(index_size_t)
         valueType = type(value)