Stop Tasks and include exception message #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czue
reviewed
Apr 27, 2020
| @@ -68,7 +68,7 @@ def get_info(self): | |||
| 'complete': True, | |||
| 'success': success, | |||
| 'progress': _get_completed_progress(), | |||
| 'result': self.result.get(self.task_id) if success else None, | |||
| 'result': self.result.get(self.task_id) if success else str(self.result.info), | |||
There was a problem hiding this comment.
is self.result.info guaranteed to exist? mostly just wondering if we need to worry about this raising an exception
There was a problem hiding this comment.
Thanks for considering my feature.
Here's the relevant section in the documentation (https://docs.celeryproject.org/en/stable/reference/celery.result.html):
If there's nothing set, self.result.info returns a None value, so str(None) will just return 'None'.
If it does throw an exception, the str() function should handle the string conversion also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted the ability to stop my tasks and pass an exception message while doing so.
This pull request facilitates that functionality.
I also updated the README file.