Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all congratulations on your great effort to write this.
I updated the code to reflect a use case where an exception is raised during task execution but I want to handle it and then show a failure in the progress bar.
To do this, I added a method stop_task to ProgressRecorder which is then called as follows:
By doing this, I fill up the progress bar to the maximum but then have a failed state for the task so that the error behaviour is triggered.
Let me know what you think about this tweak.