Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for skipped certs per client #34

Closed
goliel opened this issue Mar 5, 2024 · 1 comment
Closed

Add metric for skipped certs per client #34

goliel opened this issue Mar 5, 2024 · 1 comment

Comments

@goliel
Copy link

goliel commented Mar 5, 2024

Hi,
We have migrated our certstream server from calidog's to this one and have been enjoying the added logs and metrics.
We had an issue with our consumer being too slow and certs being skipped, we have since fixed this issue but we would like to monitor it.

Right now we only monitor at the log level, Adding metric for the skipped amount would help us follow this issue better.

@d-Rickyy-b
Copy link
Owner

Since I totally missed commenting on that one: I really liked the idea so I implemented it yesterday and released v1.6.0. Thanks for your suggestion. Please tell me if the implementation works for you or if I missed something.

The name of the client is the IP:Port and it's used as a label for the certstreamservergo_skipped_certs metric. As soon as a client disconnects, the client's metric will be removed.
Using the IP:Port as client also means that as soon as a client reconnects, it gets a different label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants