Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New word analyzer that matches full words #164

Closed
d-Rickyy-b opened this issue Jan 23, 2020 · 5 comments
Closed

New word analyzer that matches full words #164

d-Rickyy-b opened this issue Jan 23, 2020 · 5 comments
Labels
Difficulty: Easy This is an easy issue which should not take a lot of time good first issue Good for newcomers hacktoberfest Label for issues suited for the Hacktoberfest event New Analyzer For suggesting a new analyzer

Comments

@d-Rickyy-b
Copy link
Owner

Optionally this can be implemented in the already existing analyzer.
@d-Rickyy-b d-Rickyy-b added New Analyzer For suggesting a new analyzer Difficulty: Easy This is an easy issue which should not take a lot of time good first issue Good for newcomers hacktoberfest Label for issues suited for the Hacktoberfest event labels Feb 1, 2020
@abc22413
Copy link

Could I find out what such a word analyzer entails? Is it similar to a conventional word search function?

@d-Rickyy-b
Copy link
Owner Author

Hi @abc22413 - sorry for the long wait. Currently when creating a WordAnalyzer and passing "foo", it will also match occurrences of "foobar" or "barfoo". My thought was that we could create another analyzer that only matches "foo" standing alone. E.g. it would match "test foo bar" or "test foo.". This might be possible with regex and the word boundary operator \b. Translated to regex this could mean \bsearchword\b I guess.

@colincrawford colincrawford mentioned this issue Sep 25, 2020
Merged
@Pooja269
Copy link

Hi.. Can I work on this issue?

@d-Rickyy-b
Copy link
Owner Author

d-Rickyy-b commented Oct 28, 2020 •
edited
Loading

Hi @Pooja269, sure go ahead. Ping me when you need anything.

EDIT: Please check the existing PR. Maybe you can improve it.

@d-Rickyy-b
Copy link
Owner Author

Added in #194 - not merged into master yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Easy This is an easy issue which should not take a lot of time good first issue Good for newcomers hacktoberfest Label for issues suited for the Hacktoberfest event New Analyzer For suggesting a new analyzer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@d-Rickyy-b @Pooja269 @abc22413