Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add exact word analyzer and tests #194

Merged
merged 4 commits into from
Oct 1, 2020
Merged

add exact word analyzer and tests #194

merged 4 commits into from
Oct 1, 2020

Conversation

colincrawford
Copy link
Contributor

Took a stab at #164

@coveralls
Copy link

coveralls commented Sep 25, 2020 •
edited

Pull Request Test Coverage Report for Build 420

  • 138 of 139 (99.28%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 80.861%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/analyzers/tests/exactwordanalyzer_test.py 104 105 99.05%
Totals Coverage Status
Change from base Build 412: 0.6%
Covered Lines: 3304
Relevant Lines: 4086
💛 - Coveralls

@d-Rickyy-b
Copy link
Owner

Hi @colinlcrawford thanks for your contribution. Is there a reason to why you closed this PR?

@colincrawford colincrawford reopened this Oct 1, 2020
@colincrawford
Copy link
Contributor Author

@d-Rickyy-b sorry about that, just some confusion on my end - I reopened the PR

d-Rickyy-b
d-Rickyy-b requested changes Oct 1, 2020
View reviewed changes
Copy link
Owner

@d-Rickyy-b d-Rickyy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work! Thanks. Could you add a line to the changelog.md file? Then I'll instantly merge your PR :)

Thank you very much!

d-Rickyy-b
d-Rickyy-b approved these changes Oct 1, 2020
View reviewed changes
Copy link
Owner

@d-Rickyy-b d-Rickyy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :) Thank you!

@d-Rickyy-b d-Rickyy-b merged commit adcb526 into d-Rickyy-b:dev Oct 1, 2020
camfairchild added a commit to camfairchild/pastepwn that referenced this pull request Oct 4, 2020
@camfairchild
Merge pull request #1 from d-Rickyy-b/dev
d59df80 
feat: add exact word analyzer and tests (d-Rickyy-b#194)
@d-Rickyy-b d-Rickyy-b mentioned this pull request Jan 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-Rickyy-b d-Rickyy-b d-Rickyy-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colincrawford @coveralls @d-Rickyy-b