Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic Games key analyzer #97

Closed
d-Rickyy-b opened this issue Oct 6, 2019 · 5 comments
Closed

Epic Games key analyzer #97

d-Rickyy-b opened this issue Oct 6, 2019 · 5 comments
Assignees
Labels
Difficulty: Easy This is an easy issue which should not take a lot of time good first issue Good for newcomers hacktoberfest Label for issues suited for the Hacktoberfest event New Analyzer For suggesting a new analyzer

Comments

@d-Rickyy-b
Copy link
Owner

There should be a new analyzer to find pastes which contain 'Epic Games' keys. I don't expect this task to take more than 30 minutes to implement.

To solve this issue there needs to be a new analyzer added in the analyzers directory. The analyzer must follow the example of the other analyzers in this directory. Don't forget to add the analyzer to the analyzer package file.

The most simple example for such an analyzer is the AlwaysTrueAnalyzer which always returns True.

This analyzer should match any possible 'Epic Games' key. An example for the key format is K5XSH-CTLEQ-Q5RF6-U7YD9. The easiest solution would be to extend the RegexAnalyzer.

I expect unit tests to check if the analyzer works as intended. If there are questions, don't hesitate to contact me.

@d-Rickyy-b d-Rickyy-b added good first issue Good for newcomers New Analyzer For suggesting a new analyzer hacktoberfest Label for issues suited for the Hacktoberfest event Difficulty: Easy This is an easy issue which should not take a lot of time labels Oct 6, 2019
@lringham
Copy link

lringham commented Oct 6, 2019

Hey, can I be assigned to this issue?

@d-Rickyy-b
Copy link
Owner Author

@lringham Sure, now you are :) thanks for helping.

@lringham
Copy link

lringham commented Oct 7, 2019

Hey Ricky,

Which folder should contain the unit tests?

@d-Rickyy-b
Copy link
Owner Author

Hi there. In the analyzers directory there is a tests folder. There are examples of other tests already.

@synackray
Copy link
Contributor

I created #118 with the base requirements. If there are additional keys to compare against, the regex can be adjusted to not match against illegal characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Easy This is an easy issue which should not take a lot of time good first issue Good for newcomers hacktoberfest Label for issues suited for the Hacktoberfest event New Analyzer For suggesting a new analyzer
Projects
None yet
Development

No branches or pull requests

3 participants