Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facebook access token analyzer #126

Merged
merged 2 commits into from
Oct 7, 2019
Merged

facebook access token analyzer #126

merged 2 commits into from
Oct 7, 2019

Conversation

Adam-Jimenez
Copy link
Contributor

@Adam-Jimenez Adam-Jimenez commented Oct 7, 2019 •
edited

Issue: Implement Facebook access token Analyzer #125

Problems I ran into:

  • Can't run tests because I can't resolve path to test: ModuleNotFoundError: No module named 'pastepwn.analyzers.facebookaccesstokenanalyzer'
  • Could not find any examples for Facebook access tokens

@coveralls
Copy link

coveralls commented Oct 7, 2019 •
edited

Pull Request Test Coverage Report for Build 183

  • 32 of 45 (71.11%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 66.771%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/analyzers/tests/facebookaccesstokenanalyzer_test.py 25 38 65.79%
Totals Coverage Status
Change from base Build 182: 0.1%
Covered Lines: 2548
Relevant Lines: 3816
💛 - Coveralls

d-Rickyy-b
d-Rickyy-b approved these changes Oct 7, 2019
View reviewed changes
pastepwn/analyzers/tests/facebookaccesstokenanalyzer_test.py

self.obj = None
self.assertFalse(self.analyzer.match(self.obj))
def test_match_negative(self):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline 🙈

Repository owner deleted a comment Oct 7, 2019
@d-Rickyy-b d-Rickyy-b merged commit bb51e3e into d-Rickyy-b:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-Rickyy-b d-Rickyy-b d-Rickyy-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Adam-Jimenez @coveralls @d-Rickyy-b