Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gcp api key analyzer #150

Merged
merged 2 commits into from Oct 20, 2019
Merged

add gcp api key analyzer #150

merged 2 commits into from Oct 20, 2019

Conversation

grimmjow8
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 14, 2019 •
edited

Pull Request Test Coverage Report for Build 247

  • 38 of 39 (97.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 73.845%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/analyzers/tests/googleapikeyanalyzer_test.py 32 33 96.97%
Totals Coverage Status
Change from base Build 239: -1.4%
Covered Lines: 1838
Relevant Lines: 2489
💛 - Coveralls

d-Rickyy-b
d-Rickyy-b requested changes Oct 15, 2019
View reviewed changes
Copy link
Owner

@d-Rickyy-b d-Rickyy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the implementation. Could you please change the regex a bit? I added a note.

pastepwn/analyzers/googleapikeyanalyzer.py Outdated Show resolved Hide resolved
@d-Rickyy-b d-Rickyy-b merged commit 635a5e4 into d-Rickyy-b:master Oct 20, 2019
Repository owner deleted a comment Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-Rickyy-b d-Rickyy-b d-Rickyy-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grimmjow8 @coveralls @d-Rickyy-b