Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example to use pathlib, + more comments #154

Closed
wants to merge 1 commit into from
Closed

Update example to use pathlib, + more comments #154

wants to merge 1 commit into from

Conversation

psidex
Copy link
Contributor

@psidex psidex commented Oct 20, 2019

Hopefully this should be a bit more readable for beginners and should also make whats happening in the file a little clearer.

@psidex
Update example to use pathlib, + more comments
96a52f0 
Hopefully this should be a bit more readable for beginners and should also make things a little clearer
@coveralls
Copy link

Pull Request Test Coverage Report for Build 250

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.219%
Totals Coverage Status
Change from base Build 249: 0.0%
Covered Lines: 1877
Relevant Lines: 2529
💛 - Coveralls

d-Rickyy-b added a commit that referenced this pull request Oct 18, 2020
@d-Rickyy-b
feat(example): use pathlib for easier path handling
16ad498 
Based on the work of @psidex done in PR #154. I totally forgot about merging it back in the days. I can't merge the original PR, because there are also some comments in the original PR that shouldn't go in the codebase.
@d-Rickyy-b
Copy link
Owner

As explained in 16ad498 I totally forgot to merge this PR and hence created a new one. Thank you very much though @psidex! You gave me the inspiration to look into pathlib. Closing this PR.

@d-Rickyy-b d-Rickyy-b closed this Nov 1, 2020
@psidex
Copy link
Contributor Author

psidex commented Nov 1, 2020

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@psidex @coveralls @d-Rickyy-b