Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Email action #77

Closed
wants to merge 4 commits into from
Closed

Added Email action #77

wants to merge 4 commits into from

Conversation

nishu88
Copy link

@nishu88 nishu88 commented Oct 2, 2019

#59 Added a file called sendemailaction.py to actions directory and modified the action package accordingly. Used smtplib module in python3 :)

@coveralls
Copy link

coveralls commented Oct 2, 2019

Pull Request Test Coverage Report for Build 90

  • 9 of 29 (31.03%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 56.245%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/actions/sendemailaction.py 7 27 25.93%
Totals Coverage Status
Change from base Build 84: -0.6%
Covered Lines: 1396
Relevant Lines: 2482

💛 - Coveralls

Copy link
Owner

@d-Rickyy-b d-Rickyy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there :) Thank you for your work. I have several minor change requests marked in the review. It would be nice if you could have a look.

pastepwn/actions/sendemailaction.py Outdated Show resolved Hide resolved
pastepwn/actions/sendemailaction.py Outdated Show resolved Hide resolved
pastepwn/actions/sendemailaction.py Outdated Show resolved Hide resolved
@nishu88
Copy link
Author

nishu88 commented Oct 6, 2019

@d-Rickyy-b Thank you for your time in reviewing my request. I've made changes according to your suggestions. Thank you for being as descriptive as possible with the review ;)
Cheers :) #59

@d-Rickyy-b
Copy link
Owner

Sadly you deleted your branch, so I cannot merge this PR anymore. Thanks for your participation though!

@d-Rickyy-b d-Rickyy-b closed this Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants