Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bot functionality to Discord Action #86

Closed
wants to merge 3 commits into from
Closed

add Bot functionality to Discord Action #86

wants to merge 3 commits into from

Conversation

dynomite567
Copy link

Fixes #83 and adds onto #85 by adding Discord Bot functionality

Also adds discord.py as a dependency

@coveralls
Copy link

coveralls commented Oct 3, 2019

Pull Request Test Coverage Report for Build 104

  • 13 of 38 (34.21%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 58.207%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/actions/discordaction.py 11 36 30.56%
Totals Coverage Status
Change from base Build 96: -0.7%
Covered Lines: 1532
Relevant Lines: 2632

💛 - Coveralls

@d-Rickyy-b
Copy link
Owner

Hi there. I will check out your code tonight. One thing I noticed is that travis fails due to the async method not being supported in Python 3.4.

That's okay in general, but I still want to be able to build a package for python 3.4. I am not sure how I can exclude this class for the package. Maybe I will modify my travis config to delete certain analyzers for certain python versions.

Or do you know a way how to circumvent this issue?

@dynomite567
Copy link
Author

Unfortunately I do not know a way on how to circumvent this but I was thinking that maybe instead of the Webhook being the optional field, the bot optons can be the optional field. I have the change commited in the local repo and I might push the change in this request if that might work better.

@d-Rickyy-b
Copy link
Owner

Reading a bit up on this I just found this in the discord.py module https://github.com/Rapptz/discord.py/blob/68342db04dbfe8d3ffdd6ea107c37092204ff627/setup.py

extras_require in the setup.py allows optional packages. But I don't think I can exclude single files for certain python versions.


Do you think it would be a lot of work to change the code to https://github.com/b1naryth1ef/disco?
Just an idea for now.

@dynomite567
Copy link
Author

dynomite567 commented Oct 6, 2019

At first glance, I do not think it will be a lot of work, but if I cannot do it I will let you know.

@d-Rickyy-b
Copy link
Owner

@dynomite567 absolutely no worries. If that does not work out, we will find another solution. Your implementation itself looks good enough on its own. Being able to support Python 3.4 would just be a +1.

@dynomite567
Copy link
Author

It looks like @Zeroji made a PR that works way better and without dependencies, preferably what you may be looking for. As such, I am going to close this PR and and reference this one there. It's been fun helping out!

@d-Rickyy-b
Copy link
Owner

Alright, thank you a lot for your time and work! Has been fun fiddeling with discord and pastepwn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord Action
3 participants