Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage #2

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Coverage #2

wants to merge 28 commits into from

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Mar 12, 2020

Initialize coverage metrics and also update the CI to run all branches.

@HaoZeke
cmake: Add a coverage module
8eafe76
@HaoZeke
nix: Add lcov
4064a37
@HaoZeke
prj: Init coverage
edfe2a9
@HaoZeke
nix: Update nix system
1de124c
@HaoZeke
Merge branch 'master' into coverage
71733bb
@HaoZeke
coverage: Kill nix and tests
c896360
@HaoZeke
travis: Run cachix only on master
a370c11
@HaoZeke
cmake: Don't kill coverage files after generation
253d9a1
@HaoZeke
travis: Upload coverage metrics
600df6a
@HaoZeke
travis: Disable safelist for now
a97ac16
@HaoZeke
travis: Cache nix
38f552e
@HaoZeke
travis: Add local lcov and gcov
71b03ab
@HaoZeke
travis: Specialize doxygen to master only
5af0b27
@HaoZeke
travis: More master only work
1af919f
@HaoZeke
travis: Use native nix specialize master builds
39ec6ca
@HaoZeke
script: Make an executable script
5e2fbf4
@HaoZeke
travis: Run shell script in a pure environment
aa24ec7
@HaoZeke
travis: Get the path right
5fa2b8a
@HaoZeke
cmake: Gcov is there
717dc6c
@HaoZeke
cmake: Refactor coverage
767af1e
@HaoZeke
travis: Try without success
2cc9527
@HaoZeke
travis: Refactor to run coverage everywhere
ea8bb88
@HaoZeke
travis: Be explicit about caches
7b6bc0e
@HaoZeke
readme: Add codecov badge
34c0bee
@HaoZeke
travis: Update caching as per the wiki
d3f2da6
@HaoZeke
travis: Forcefully add the main cache
6a10e78
@HaoZeke HaoZeke added the enhancement New feature or request label Mar 12, 2020
@HaoZeke HaoZeke linked an issue Mar 12, 2020 that may be closed by this pull request
Add coverage metrics #3
Open
@HaoZeke HaoZeke requested a review from amritagos March 12, 2020 03:22
@HaoZeke HaoZeke added this to the Quality Management milestone Mar 12, 2020
amritagos
amritagos requested changes Mar 12, 2020
View reviewed changes
Copy link
Member

@amritagos amritagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments and update the PR.
Thanks for this!

.travis.yml Outdated Show resolved Hide resolved
CMakeLists.txt
Comment on lines +236 to +237
set(CMAKE_CXX_FLAGS "-g -O0 -fprofile-arcs -ftest-coverage")
set(CMAKE_C_FLAGS "-g -O0 -fprofile-arcs -ftest-coverage")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be only set for the Debug builds?

nix/nixpkgs/default.src.json
Comment on lines -5 to +6
"rev": "ae002fe44e96b868c62581e8066d559ca2179e01",
"sha256": "1bawyz3ksw2sihv6vsgbvhdm4kn63xrrj5bavg6mz5mxml9rji89"
"rev": "8130f3c1c2bb0e533b5e150c39911d6e61dcecc2",
"sha256": "154nrhmm3dk5kmga2w5f7a2l6j79dvizrg4wzbrcwlbvdvapdgkb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change and should be documented a bit more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I'll update the PR description. Though the changes shouldn't affect general users much. A good practice is running nix-collect-garbage whenever the nix versions are updated.

@HaoZeke HaoZeke self-assigned this Mar 12, 2020
@HaoZeke @amritagos
travis: Fix typo
6d9d26a 
Co-Authored-By: Amrita Goswami <32496815+amritagos@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 12, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@570f134). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   60.86%           
=========================================
  Files             ?        7           
  Lines             ?      920           
  Branches          ?        0           
=========================================
  Hits              ?      560           
  Misses            ?      360           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 570f134...2057841. Read the comment docs.

@d-SEAMS d-SEAMS deleted a comment from amritagos Mar 12, 2020
@HaoZeke HaoZeke force-pushed the master branch 2 times, most recently from d9d9add to fd1651f Compare March 17, 2021 22:43
@HaoZeke HaoZeke force-pushed the main branch 8 times, most recently from 8239a8b to 3665a68 Compare March 20, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amritagos amritagos amritagos requested changes

Assignees

@HaoZeke HaoZeke

Labels
enhancement New feature or request
Projects
None yet
Milestone
Quality Management
Development

Successfully merging this pull request may close these issues.

Add coverage metrics
2 participants
@HaoZeke @amritagos