BLD: Work on MacOS, use as a subproject #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be easier to review after being rebased on #38 |
HaoZeke
requested changes
Aug 16, 2023
To allow seams-core to be used as a sub-project
HaoZeke
reviewed
Aug 23, 2023
| @@ -15,7 +15,7 @@ | |||
| # The project is seams-core, the executable is yodaStruct | |||
| project('seams-core', 'cpp', | |||
| version : '1.0.1', | |||
| default_options : ['warning_level=3', 'cpp_std=c++17']) | |||
| default_options : ['warning_level=3', 'cpp_std=c++14']) | |||
There was a problem hiding this comment.
This is a little complicated, sol2 v.3 requires at-least C++17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to clone pyseam in my Macos, it threw some errors. I did the following to fixup:
I opened a Macos issue in the beginning. This pull request will resolve it.
Closes #25.