refactor(luhn): remove sumi

d-edge · Sep 21, 2021 · a2979ed · a2979ed
1 parent ea2acf6
commit a2979ed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Cardidy/Extensions.cs b/Cardidy/Extensions.cs
@@ -23,6 +23,4 @@ internal static int PadRight(this int source, int totalWidth, int paddingValue)
     }
 
     internal static int ToNumber(this IEnumerable<int> digits) => digits.Aggregate((digit, sum) => digit * 10 + sum);
-
-    internal static int Sumi(this IEnumerable<int> source, Func<int, int, int> f) => source.Select(f).Sum();
 }
diff --git a/Cardidy/Model/ALuhnCard.cs b/Cardidy/Model/ALuhnCard.cs
@@ -6,7 +6,7 @@ internal abstract record ALuhnCard : ACard
 
     internal ALuhnCard(CardType name, IEnumerable<int> prefixes, IEnumerable<int> lengths) : this(name, prefixes.Select(x => new PaddedRange(x)), lengths) { }
 
-    internal ALuhnCard(CardType name, int prefix, IEnumerable<int> lengths) : this(name, new[] { new PaddedRange(prefix)}, lengths) { }
+    internal ALuhnCard(CardType name, int prefix, IEnumerable<int> lengths) : this(name, new[] { new PaddedRange(prefix) }, lengths) { }
 
     public override bool Check(IEnumerable<int> digits) => CheckLuhn(digits);
 
@@ -20,7 +20,9 @@ internal abstract record ALuhnCard : ACard
     /// <returns>true/false depending on valid checkdigit</returns>
     private static bool CheckLuhn(IEnumerable<int> digits) => digits
         .Reverse()
-        .Sumi((thisNum, i) => i % 2 == 0
+        .Select((thisNum, i) =>
+            i % 2 == 0
             ? thisNum
-            : ((thisNum *= 2) > 9 ? thisNum - 9 : thisNum)) % 10 == 0;
+            : ((thisNum *= 2) > 9 ? thisNum - 9 : thisNum))
+        .Sum() % 10 == 0;
 }