feat(type-expand-provider.ts): expand the first level of tree item automatically #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senkenn
changed the title
Closed
d-kimuson
requested changes
Sep 11, 2023
| @@ -77,6 +90,7 @@ export class TypeExpandProvider | |||
| } | |||
|
|
|||
| this.selection = selection | |||
| this.topElement = undefined | |||
There was a problem hiding this comment.
📝
- 選択している Node が変わったときに topElement をリセット
- topElement (リセット後初めて getElement で呼ばれたもの) なら展開して topElement 持たせる → 2回目以降は topElement に Elemetn があるので更新されているので折りたたんだ状態に更新して返す
| @@ -16,6 +16,7 @@ export class TypeExpandProvider | |||
| type: TypeObject | |||
| } | |||
| private activeFilePath: string | undefined | |||
| private topElement?: ExpandableTypeItem | |||
There was a problem hiding this comment.
[want] 欲しいのは表示済みかの状態だけなので、boolean で十分で意図が読みやすいかなと思いました！Element 自体持たせている意図が特になければこちらでお願いしたいです！
Suggested change
| private topElement?: ExpandableTypeItem | |
| private isAlreadyShowTopElement: boolean = false |
| element.collapsibleState = vscode.TreeItemCollapsibleState.Expanded | ||
| this.topElement = element | ||
| } else { | ||
| element.collapsibleState = vscode.TreeItemCollapsibleState.Collapsed |
There was a problem hiding this comment.
[q] ここの collapsibleState の更新って展開できないものは None、展開できるものは Collapsed で来ると思うので明示的な更新は不要そうに見えたんですが、わかりやすく明示している感じですかね？
There was a problem hiding this comment.
確かに不要ですね。手前の
// The bottom layer element is not expandable
if (element.collapsibleState === vscode.TreeItemCollapsibleState.None) {
return element
}も結局「展開できないものは Noneで来る」を前提に条件書いてるのでelseは削除します。
d-kimuson
added a commit
that referenced
this pull request
Sep 11, 2023
|
この PR に関する Changelog は記入済み Approve 次第取り込んだバージョンをリリースします 🙆♂️ |
|
@senkenn PRありがとうございました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#337