Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint functionality #14

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Fingerprint functionality #14

merged 3 commits into from
Nov 16, 2023

Conversation

Racopokemon
Copy link
Collaborator

Adressing #4, this is a simple fingerprinting functionality including a test case.
This commit also fixes a potential issues with file-splitting when adding further data to an already compressed benchmark.

@d-krupke
Copy link
Owner

Nice job!

@d-krupke d-krupke merged commit 8b8d708 into main Nov 16, 2023
3 checks passed
@d-krupke
Copy link
Owner

You could have used sorted() instead of .sort to save one line. But this is just a minor style thing.

@Racopokemon
Copy link
Collaborator Author

I was not aware that sorted() was an option, it actually annoyed me when I realized that the .sort() would cost me an additional line. Thanks for mentioning it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants