Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unStickElement() sets z-index to 10 instead of restoring original z-index (or no z-index) #149

Open
rDr4g0n opened this issue Jun 22, 2016 · 0 comments
Open

unStickElement() sets z-index to 10 instead of restoring original z-index (or no z-index) #149

rDr4g0n opened this issue Jun 22, 2016 · 0 comments

Comments

@rDr4g0n
Copy link
Contributor

rDr4g0n commented Jun 22, 2016

unStickElement() has a hardcoded z-index of 10, where other properties that are restored on unstick are taken from initialCSS. z-index is preset in initialCSS, so setting it back to the previous value should be easy. If forcing it to 10 is intentional, maybe add a comment to describe the reason for the behavior.
nonplus added a commit to nonplus/ngSticky that referenced this issue Dec 2, 2016
@nonplus
fix: properly restore z-index - d-oliveros#149
cf33408
nonplus added a commit to nonplus/ngSticky that referenced this issue Dec 2, 2016
@nonplus
fix: properly restore style attributes when unsticking - d-oliveros#149
5c1da32
nonplus added a commit to nonplus/ngSticky that referenced this issue Apr 28, 2017
@nonplus
fix: restore style attributes when unsticking - d-oliveros#149
62b1b19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rDr4g0n