Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing with Smooth Font mod #5

Closed
Cryptic-Soldier opened this issue Aug 31, 2019 · 7 comments
Closed

Crashing with Smooth Font mod #5

Cryptic-Soldier opened this issue Aug 31, 2019 · 7 comments

Comments

@Cryptic-Soldier
Copy link

So I am running both this mod and the Smooth Font mod in vanilla 1.12.2 on the latest version of Forge for this MC version.

Upon clicking on the enchantment table, this mod crashes, causing the game to crash.

I'm have narrowed it down to smooth font and this clashing.

I've included a crash report which can be viewed here: https://pastebin.com/4pwEuQVC

I have also forwarded this to the Smooth Font developers as well on the Curse Forge website.

@d0sboots
Copy link
Owner

d0sboots commented Aug 31, 2019 via email

@Cryptic-Soldier
Copy link
Author

I'm not super surprised; my mod ends up redoing a lot of font-related calculations because it's not set up to allow reuse of the existing parts of the enchanting UI. I'll look into it when I get the chance.

On Sat, Aug 31, 2019, 06:25 Cryptic-Soldier @.***> wrote: So I am running both this mod and the Smooth Font mod in vanilla 1.12.2 on the latest version of Forge for this MC version. Upon clicking on the enchantment table, this mod crashes, causing the game to crash. I'm have narrowed it down to smooth font and this clashing. I've included a crash report which can be viewed here: https://pastebin.com/4pwEuQVC I have also forwarded this to the Smooth Font developers as well on the Curse Forge website. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AADQHODKYVSO7TJ7ZG6VR6TQHJWMZA5CNFSM4ISTVYM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HISZBEA>, or mute the thread https://github.com/notifications/unsubscribe-auth/AADQHOBJI5DRLULIY4HQK2TQHJWMZANCNFSM4ISTVYMQ .

Thank you so much for looking into it.

I've tried all of the options disabled/enabled and countless different mixes of the options enabled/disabled, it crashes every time. If I can be of any assistance, please let me know.

@d0sboots
Copy link
Owner

d0sboots commented Aug 31, 2019 via email

@Cryptic-Soldier
Copy link
Author

Yeah, afaict enabling/disabling in the menu doesn't really do much? Until it's fixed, you'll have to disable EnchantmentRevealer completely (or smooth font, if you prefer).

Which setting is that, as I can't seem to find it.

So I have them both enabled, as the game and this mod doesn't crash until I try to use the enchanting table, that's when this mod crashes. I tested all of my mods, and everything is fine with this one, except Smooth Font. The two don't seem to want to get along for some reason.

So if I want to enchant, I've got to back all the way out of my game, disable smooth font (since it can't be done in the game w/ forge), go back in, enchant, go back out, enable smooth font, resume playing.

@d0sboots
Copy link
Owner

d0sboots commented Sep 1, 2019 via email

@d0sboots
Copy link
Owner

Good news (that maybe you discovered yourself): This issue is fixed with SmoothFont version 2.1.1! I suspect the relevant line in their changlog is this one:
"- Improved the compatibility with the certain mods which refers charWidth field for the compatibility with OptiFine. (Issue-#23)"

In any case, I was able to reproduce the crash with version 2.1 (the version your report said you were using), but it worked fine for me with 2.1.1. Most of the text renders with SmoothFont, but some text (the part where I had to re-implement rendering to get a scrolling effect) permanently renders with the default Minecraft font, which looks ugly. But at least it works!

@d0sboots
Copy link
Owner

d0sboots commented Dec 2, 2019

This also caused my to re-evaluate how I was doing things, and I realized I could get rid of that custom code. EnchantmentRevealer v1.3 now works even with SmoothFont 2.1, and all the text renders with the font that SmoothFont chooses. This should improve compatibility with other font-related mods, as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants