Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 29 formula #597

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dustinfarris
Copy link
Contributor

@dustinfarris dustinfarris commented Aug 2, 2023

Addressing @d12frosted comments in #593 to update 29 target and documentation.

Also includes ahead-of-time native compilation flag. I added this as a separate flag from regular native compilation — lmk if you'd prefer a different approach.

Closes #595

@dustinfarris
Copy link
Contributor Author

@d12frosted I am able to install this with ./build 29 but when I try to install from hombrew i get an error:

brew tap dustinfarris/homebrew-emacs-plus ~/code/homebrew-emacs-plus
brew install emacs-plus --with-modern-sexy-v2-icon --with-dbus --with-native-comp-aot --with-no-frame-refocus

==> Fetching dustinfarris/emacs-plus/emacs-plus@29
==> Downloading https://ftp.gnu.org/gnu/emacs/emacs-29.1.tar.xz
################################################################################################################################################################################################ 100.0%
==> Installing emacs-plus@29 from dustinfarris/emacs-plus
==> Patching
Error: An exception occurred within a child process:
  Errno::ENOENT: No such file or directory @ rb_sysopen - /Users/a80291516/patches/emacs-29/no-frame-refocus-cocoa.patch

I was not getting this error when installing in this way on aff45bb

@d12frosted
Copy link
Owner

brew tap dustinfarris/homebrew-emacs-plus ~/code/homebrew-emacs-plus

Never tested the 'local_patch' helper with custom path for tap. Try tapping without custom path :)

Copy link
Owner

@d12frosted d12frosted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 thank you very much! that's exactly what needs to be done

if possible, extract aot as a separate PR 🙏 would love to keep commits clean
for you it will be extra contribution ;)


url "https://github.com/emacs-mirror/emacs.git", :branch => "emacs-29"

if build.with? "native-comp" and build.with? "native-comp-aot"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally I would love to introduce extra option separately from 29.1 release

p.s. what is the difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split the commit to 2 commits. Do you still want a separate PR for the ahead-of-time commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference?

all core elisp gets compiled immediately instead of just-in-time during usage.

Users can now choose between --with-native-comp or
--with-native-comp-aot which will set the --with-native-comp compile
flag to `yes` or `aot` respectively.
@dustinfarris
Copy link
Contributor Author

brew tap dustinfarris/homebrew-emacs-plus ~/code/homebrew-emacs-plus

Never tested the 'local_patch' helper with custom path for tap. Try tapping without custom path :)

This was because i was tapping (arbitrarily) to dustinfarris/homebrew-emacs-plus but the urlresolver is hard-coded to expect d12frosted.

Once I resolved that I'm able to tap locally and install successfully.

@d12frosted
Copy link
Owner

Thank you! I cherry picked your first two commits. Please open a separate PR for AOT. And don't forget to add this option to documentation 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emacs 29.1 has been released
2 participants