Skip to content

Commit

Permalink
[Fix] Declare things before using them
Browse files Browse the repository at this point in the history
Summary:
We always spit out the .fws.h file after the corresponding .h file. But the
.fws.h file can never depend on anything in the .h file (it just declares
StaticStrings, ScalarArrays and other compile time constants).

I dont think the .h file should depend on the .fws.h file either - but we found
a case where it did. I'll try to find a better fix, but including the .fws.h
should be completely safe, and fixes the immediate issue.

Test Plan: fast_tests slow_tests

Reviewers: qigao, myang

Reviewed By: myang

CC: edward, ps, mwilliams, myang

Differential Revision: 341485

Task ID: 756563
  • Loading branch information
mwilliams authored and macvicar committed Oct 18, 2011
1 parent 20ac8e7 commit 59bac70
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/compiler/analysis/analysis_result.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4713,8 +4713,8 @@ void AnalysisResult::outputCPPClusterImpl(CodeGenerator &cg,
getTrueDeps(fs, toInclude);
}
BOOST_FOREACH(FileScopePtr fs, files) {
cg_printInclude(fs->outputFilebase());
cg_printInclude(fs->outputFilebase() + ".fws");
cg_printInclude(fs->outputFilebase());
toInclude.erase(fs->getName());
}
cg.printSection("Dependencies");
Expand Down

0 comments on commit 59bac70

Please sign in to comment.