Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename QNCRITICAL logging macro to QNERROR and get rid of Fatal log level #34

Closed
d1vanov opened this issue Dec 5, 2017 · 1 comment
Closed

Rename QNCRITICAL logging macro to QNERROR and get rid of Fatal log level #34

d1vanov opened this issue Dec 5, 2017 · 1 comment
Labels
Done: development Done: master task

Comments

@d1vanov
Copy link
Owner

d1vanov commented Dec 5, 2017

Fatal log level in several logging frameworks terminates the application in addition to printing the "fatal" log entry. Currently libquentier's fatal log level doesn't terminate the application and thus can be the source of confusion. On the other hand, I don't really want to encourage anyone to terminate the application in this way as well. So it's better to just get rid of this log level and replace its occurrences within the source code by Error log entries or even Warning log entries.

Also need to change QNCRITICAL macro to QNERROR since that would actually correspond to Error log level.
@d1vanov
Copy link
Owner Author

d1vanov commented Dec 6, 2017 •
edited
Loading

Done in commit f5aeb00 in branch development.

@d1vanov d1vanov added the task label Dec 7, 2017
@d1vanov d1vanov closed this as completed Dec 7, 2017
d1vanov added a commit that referenced this issue Dec 7, 2017
@d1vanov
Issue #34: get rid of fatal log level + rename macro corresponding to…
f5aeb00 
… error log level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Done: development Done: master task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d1vanov