docs: add appearance control to toast story #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uffizzi Preview Environment
|
vacas5
approved these changes
Dec 5, 2022
nataliepina
reviewed
Dec 5, 2022
nataliepina
requested changes
Dec 5, 2022
seialkali
force-pushed
the
seialkali/docs/add-toast-appearance-control
branch
from
6666899
to
b58da67
Compare
nataliepina
approved these changes
Dec 5, 2022
seialkali
force-pushed
the
seialkali/docs/add-toast-appearance-control
branch
8 times, most recently
from
c63df4b
to
9ada95c
Compare
seialkali
changed the base branch from
main
to
seialkali/ci/playwright-install-fix
seialkali
changed the base branch from
seialkali/ci/playwright-install-fix
to
main
seialkali
force-pushed
the
seialkali/docs/add-toast-appearance-control
branch
2 times, most recently
from
5155fa2
to
a3aed4e
Compare
seialkali
force-pushed
the
seialkali/docs/add-toast-appearance-control
branch
from
a3aed4e
to
f61ea92
Compare
|
Uffizzi Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an appearance control to the Toaster story. Since the Toast story needs both the Toaster and Toast component, we had to add the Toaster component as a decorator in order to get the appearance control to work properly. However, it only works for the stories that have the Toast component(s) as a direct child/children of the Toaster component (or wrapped in a fragment). It does not work for the stories where there's maps or the Toast component is in an array.
Since the appearance control will only work on some of the stories, I've installed the @storybook/addon-controls package so that I can disable controls on the stories which the appearance control will not work.
Which issue(s) does this PR relate to?
Testing
Go to the Toaster story in story book and confirm that you can change the appearance control for Default, Description, and Multi Toast story. Also confirm that you can not use the controls for the rest of the stories.
Trade-offs
Screenshots
Checklist