refactor: change all onKeyPress uses to use onKeyDown instead #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uffizzi Preview Environment☁️ https://app.uffizzi.com//github.com/d2iq/ui-kit/pull/927 ⚙️ Updating now by workflow run 4129180998. What is Uffizzi? Learn more |
mstruebing
approved these changes
Feb 9, 2023
nataliepina
approved these changes
Feb 9, 2023
|
🎉 This PR is included in version 12.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes all uses of
onKeyPresstoonKeyDowninButtonCard,clickable, andTextInputWithBadges. I have also renamed a few functions that contain key press in the name to key down for consistency as well as replaced references ofonKeyPressto beonKeyDown.Which issue(s) does this PR relate to?
#915
Testing
Storybook and run tests
Checklist