fix: SlideToggle console errors #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes D2IQ-98165
nataliepina
changed the title
|
Uffizzi Preview |
mstruebing
approved these changes
Jul 11, 2023
| const parentDataCy = [ | ||
| `${inputType}`, | ||
| ...(checked ? [`${inputType}.checked`] : []), | ||
| ...(appearance && appearance !== InputAppearance.Standard | ||
| ? [`${inputType}.${appearance}`] | ||
| : []) | ||
| ].join(" "); | ||
|
|
There was a problem hiding this comment.
After seeing a lot of code blocks recently with no blank lines in between at all I'm really pleased to see this!
There was a problem hiding this comment.
Yes, glad you think so too!
|
🎉 This PR is included in version 14.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes D2IQ-98165
Description
I discovered console errors around the SlideToggle component. One around the value and one around checked. The error suggests the use of defaultValue and defaultChecked. Using these resolved the error.
You provided a `value` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultValue`. Otherwise, set either `onChange` or `readOnly`.Which issue(s) does this PR relate to?
Testing
View the console while looking at the SlideToggle story.
Trade-offs
Screenshots'
Before
After
Checklist