Feat: Enable d2l default tab even if few notebooks have missing default #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable primary tabs of our choice feature on d2lbook. Earlier if the tab was missing, for example pytorch recommender system is not available; the html build failed). This issue has been fixed in this PR by checking all tabs equally for their file size.
When a notebook has a missing default tab, we automatically fallback to the tabs which are present. Example in recommender systems, pytorch is missing so mxnet will become default there.
See http://preview.d2l.ai/d2l-en/PR-2098/ andd http://ci.d2l.ai/blue/organizations/jenkins/d2l-en/detail/PR-2098/6/pipeline/ for the demo pytorch default version of d2l.