[PyTorch] Use reduction=none for train_epoch_ch3 #2007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixes loss not showing up in the following sections:
I'll look at other sections that might be affected. Note that
l.mean()
is required otherwise when usingl.sum()
with PyTorch CrossEntropy (with no reduction) the loss overshoots. This change will not affect any other notebooks becaused2l.train_ch3
is only used in these notebooks, so it won't break any other section.By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.