Fix #2250 colab missing matplotlib_inline
#2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job d2l-en/PR-2254/1 is complete. |
|
Thanks. Please proceed with the patch release. |
AnirudhDagar
added a commit
to AnirudhDagar/d2l-en
that referenced
this pull request
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #2250 without adding any new dependency in d2l package.
jupyteralready indirectly installsipython, but now we force ipython to be at a minimum version 7.23 (released in 2019). This v7.23 release added thematplotlib_inlinedependency to ipython, so it will automatically fix the missing dep package issue.@astonzhang let's make a patch release and for
d2lsince this has affected all our notebooks in colab with their recent change.