Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix broken preview path for release #2278

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

AnirudhDagar
Copy link
Member

The logic for release preview is updated.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

static/build_html.sh Outdated Show resolved Hide resolved
@d2l-bot
Copy link
Member

d2l-bot commented Aug 29, 2022

Job d2l-en/PR-2278/1 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2278/

@AnirudhDagar
Copy link
Member Author

I've made the code more readable, addressing the comments. Please review again @astonzhang thanks! 🙌🏼

Jenkinsfile Outdated Show resolved Hide resolved
static/build_html.sh Outdated Show resolved Hide resolved
static/build_html.sh Outdated Show resolved Hide resolved
static/build_html.sh Show resolved Hide resolved
Co-authored-by: Aston Zhang <22279212+astonzhang@users.noreply.github.com>
@d2l-bot
Copy link
Member

d2l-bot commented Aug 29, 2022

Job d2l-en/PR-2278/2 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2278/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 29, 2022

Job d2l-en/PR-2278/3 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2278/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 29, 2022

Job d2l-en/PR-2278/4 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2278/

@astonzhang astonzhang merged commit 1812ce5 into d2l-ai:master Aug 29, 2022
@AnirudhDagar AnirudhDagar deleted the preview_fix branch August 29, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants