Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ESC to close/cancel dialogs #1324

Closed
SumatraPeter opened this issue Apr 11, 2022 · 2 comments
Closed

Enable ESC to close/cancel dialogs #1324

SumatraPeter opened this issue Apr 11, 2022 · 2 comments

Comments

@SumatraPeter
Copy link

SumatraPeter commented Apr 11, 2022

In Windows itself for example, the delete dialog can be closed/canceled simply by pressing ESC. In IG's delete confirmation dialog however ESC does nothing.

So it would be nice if IG's dialogs also responded to ESC to close/cancel them.

(Speaking of delete confirmation dialogs, while I like that IG's displays the full path to the file, it would be better if it also displayed the image dimensions and size like Windows' delete confirmation dialog does, which would be useful when one is in fullscreen mode with the titlebar and toolbar hidden.)

@d2phap
Copy link
Owner

d2phap commented Apr 27, 2022

Those are dialogs opened by MessageBox.Show() function do not support closing by ESC key.
Most of them are for showing error message.

The rest can be closed by ESC, e.g. Rename dialog, Go to dialog, Custom zoom dialog,...
I will need to replace the MessageBox by the custom dialog component.

@d2phap d2phap added this to the v9.0 beta 2 milestone Jun 22, 2022
@d2phap
Copy link
Owner

d2phap commented Sep 6, 2022

All dialogs in v9.0 beta 2 support closing / cancelling by ESC.

@d2phap d2phap closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants