Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Voronoi diagram for entirely-collinear input? #20

Closed
mbostock opened this issue Mar 21, 2018 · 1 comment
Closed

Define Voronoi diagram for entirely-collinear input? #20

mbostock opened this issue Mar 21, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

This throws an error (No Delaunay triangulation exists for this input):

Delaunay.from([[0, 0], [1, 1], [2, 2]])

But like #19, there is a valid Voronoi diagram for this input! The problem is that all the cells have infinite sides and no points. Hrm.
@mourner mourner added the enhancement New feature or request label Mar 23, 2018
@chnn chnn mentioned this issue Apr 10, 2018
Closed
@mbostock mbostock mentioned this issue Sep 10, 2018
Closed
@plouc plouc mentioned this issue Dec 22, 2018
Closed
@mbostock mbostock mentioned this issue Jan 10, 2019
Closed
@domoritz domoritz mentioned this issue Feb 21, 2019
Merged
@serendipity1004 serendipity1004 mentioned this issue May 14, 2019
Closed
@Fil Fil mentioned this issue May 22, 2019
Closed
Fil added a commit that referenced this issue Jun 19, 2019
@Fil
Upgrade to Delaunator@4
2ee9847 
Fix Delaunay and Voronoi for degenerate cases

For 0, 1, 2 points, and for collinear points:
- returns the correct topology (neighbors, find)
- returns the correct Voronoi cells (bounding box, half plane…)
- resorts to deterministic jittering only in the case of multiple collinear points

Fixes:
-  #19
-  #20
-  #50
-  #65
@Fil
Copy link
Member

Fil commented Jun 20, 2019

Fixed by 2ee9847

@Fil Fil closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fil @mourner @mbostock