Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace d3-voronoi with d3-delaunay. #1594

Merged
merged 8 commits into from Aug 22, 2019
Merged

Replace d3-voronoi with d3-delaunay. #1594

merged 8 commits into from Aug 22, 2019

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Feb 21, 2019 •
edited

Fixes #1492

@domoritz domoritz requested a review from jheer February 21, 2019 00:20
@jheer
Copy link
Member

jheer commented Feb 21, 2019

Thanks for the PR! The failing tests are due to the test scene for the airports example, where the voronoi polygon path strings have changed.

I don't want to merge until we have a solution in place for d3/d3-delaunay#19. Vega can certainly encounter voronoi instances with less than 3 input points.

@domoritz
Copy link
Member Author

Yeah, I agree that d3/d3-delaunay#19 is a blocker for us. I wonder whether @mourner or @mbostock have this issue on their queue.

@domoritz
Copy link
Member Author

There is also d3/d3-delaunay#20 but it's less of an issue.

@jheer
Copy link
Member

jheer commented Feb 21, 2019

Hmm, I think d3/d3-delaunay#20 is absolutely a blocker as well. I've seen Vega users generate collinear points for a Voronoi diagram to enable a form of "nearest" selection.

jheer
jheer requested changes Feb 21, 2019
View reviewed changes
Copy link
Member

@jheer jheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need solutions for outstanding issues in d3-delaunay before this can be considered.

@jheer jheer added the icebox For archiving issues not scheduled for work label Feb 23, 2019
@jheer jheer force-pushed the master branch 2 times, most recently from fe8655f to 2438f34 Compare March 25, 2019 05:41
@domoritz
Copy link
Member Author

d3/d3-delaunay#20 has been fixed

@domoritz domoritz removed the icebox For archiving issues not scheduled for work label Jul 17, 2019
@domoritz
Copy link
Member Author

@jheer I updated the PR and fixed any remaining issues. Can you rebuild the airport example? I tried it locally and tests are passing but the results differ from what's happening on Travis.

@domoritz
Copy link
Member Author

domoritz commented Aug 3, 2019

Ahh, it's because of #1893

@domoritz domoritz requested a review from jheer August 21, 2019 14:14
@domoritz
Copy link
Member Author

I updated to the latest version of d3-delaunay and fixed the build. This is ready to go (squashed).

@domoritz domoritz merged commit 48deb40 into master Aug 22, 2019
@domoritz domoritz deleted the dom/delaunay branch August 22, 2019 08:19
@jheer
Copy link
Member

jheer commented Aug 22, 2019

Why did you merge? I am working on this... Ugh.

@domoritz
Copy link
Member Author

Ups, I took the approval as a permission to merge. I squashed all of the changes into one commit so hopefully it's not too confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock left review comments

@jheer jheer jheer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace d3 voronoi with d3 delaunay
3 participants
@domoritz @jheer @mbostock