Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delaunay.update #69

Closed
wants to merge 5 commits into from
Closed

Delaunay.update #69

wants to merge 5 commits into from

Conversation

Fil
Copy link
Member

@Fil Fil commented Jun 19, 2019 •
edited

fixes #68. I don't like the list of all properties in the code, there's probably a more elegant solution?

Fil added 2 commits May 24, 2019 15:20
@Fil
upgrade to delaunator@3
bbf0c8e 
fixes #50

removes delaunay.outedges from the API, replaced with the private _hullIndex
@Fil
Upgrade to Delaunator@4
2ee9847 
Fix Delaunay and Voronoi for degenerate cases

For 0, 1, 2 points, and for collinear points:
- returns the correct topology (neighbors, find)
- returns the correct Voronoi cells (bounding box, half plane…)
- resorts to deterministic jittering only in the case of multiple collinear points

Fixes:
-  #19
-  #20
-  #50
-  #65
@Fil Fil requested a review from mourner June 19, 2019 19:45
@Fil
Copy link
Member Author

Fil commented Jun 20, 2019

testing here https://observablehq.com/d/b301cc346b009686

mourner
mourner reviewed Jun 20, 2019
View reviewed changes
src/delaunay.js Outdated Show resolved Hide resolved
src/delaunay.js Outdated Show resolved Hide resolved
mourner
mourner reviewed Jun 20, 2019
View reviewed changes
src/delaunay.js Outdated Show resolved Hide resolved
@Fil
Copy link
Member Author

Fil commented Jun 20, 2019

Squashed and merged with 5dcc818

@mourner please push to npm as version 5.0.0 — I don't have the rights to the package.

@Fil Fil closed this Jun 20, 2019
@mourner
Copy link
Contributor

mourner commented Jun 20, 2019

@Fil I don't too — @mbostock is the only one in npm owner ls. Mike, want to publish the new major version and/or add us as owners on NPM?

@JobLeonard
Copy link

testing here observablehq.com/d/b301cc346b009686

This is fun, looks almost alive: https://observablehq.com/d/ad7f414084bc3680

Really looking forward to this! :D

@mbostock
Copy link
Member

Apologies for the delay, but I’ve added @mourner and @Fil as owners of d3-delaunay. Thanks for the help y’all!

@Fil Fil deleted the delaunay.update branch July 9, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an update method for relaxation algorithms
4 participants
@Fil @mourner @JobLeonard @mbostock