Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking regression in v5.8.0 #135

Closed
rkirsling opened this issue Mar 14, 2019 · 1 comment
Closed

Breaking regression in v5.8.0 #135

rkirsling opened this issue Mar 14, 2019 · 1 comment

Comments

@rkirsling
Copy link

Although it was part of a minor release, #124 is a breaking change.

In particular, if we follow the docs and set fx and fy to null upon drag end (as in Force Dragging III), then we're in for some absurd behavior when we call simulation.nodes on our next data update.
(See Directed Graph Editor for a complete example.)

Setting them to undefined does work, since isNaN(undefined) is false while isNaN(null) is true.

mbostock added a commit that referenced this issue Mar 14, 2019
@rkirsling
Copy link
Author

Thanks a bunch for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant