Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing "resolve" dependency #161

Closed
joearasin opened this issue Jan 22, 2019 · 1 comment · Fixed by #162
Closed

Missing "resolve" dependency #161

joearasin opened this issue Jan 22, 2019 · 1 comment · Fixed by #162

Comments

@joearasin
Copy link

https://www.npmjs.com/package/resolve is required by https://github.com/d3/d3-geo-projection/blob/master/bin/resolve.js, but not included as a dependency. This causes scripts to fail with Cannot find module 'resolve'
Fil added a commit that referenced this issue Jan 23, 2019
@Fil
dependency: resolve
43105df 
fixes #161
@Fil Fil mentioned this issue Jan 23, 2019
Merged
@Fil
Copy link
Member

Fil commented Jan 23, 2019

Indeed, it should have been in 1f7c507.

Should be fixed by #162

@Fil Fil closed this as completed in #162 Jan 31, 2019
Fil added a commit that referenced this issue Jan 31, 2019
@Fil
dependency: resolve
56b1ebd 
fixes #161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dependency: resolve d3/d3-geo-projection
2 participants
@joearasin @Fil