Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax d3-array dependency to 1-2. #177

Closed
mbostock opened this issue Jul 21, 2019 · 3 comments
Closed

Relax d3-array dependency to 1-2. #177

mbostock opened this issue Jul 21, 2019 · 3 comments

Comments

@mbostock
Copy link
Member

Currently the package.json says this module depends on d3-array@1, but it‘s also compatible with d3-array@2, so we should allow that.
@Fil
Copy link
Member

Fil commented Sep 11, 2019

Setting "d3-array": "1 - 2" in package.json seems to work (all tests are green).

Note that d3-geo and probably quite a few other modules could benefit from the same.

Fil added a commit to d3/d3-geo-polygon that referenced this issue Sep 29, 2019
@Fil
Relax d3-array dependency to 1-2
404b970 
Ref. d3/d3-geo-projection#177
Fil added a commit that referenced this issue Sep 29, 2019
@Fil
Relax d3-array dependency to 1-2
ba36d39 
Ref. #177
@Fil Fil closed this as completed Sep 29, 2019
Fil added a commit to d3/d3-geo that referenced this issue Sep 29, 2019
@Fil
Relax d3-array dependency to 1-2
5052cd0 
Ref. d3/d3-geo-projection#177
@gordonwoodhull gordonwoodhull mentioned this issue Sep 30, 2019
Closed
@Fil
Copy link
Member

Fil commented Nov 12, 2019 •
edited

I think we'll have the same webpack problem here as in d3/d3-geo#176 ; reverting for now.

I'm leaving the change in https://github.com/d3/d3-geo-polygon/releases/tag/v1.8.2 though: no one complained about it, probably because no one uses it :)

@Fil Fil reopened this Nov 12, 2019
Fil added a commit that referenced this issue Nov 12, 2019
@Fil
reverting d3-array dependency to @1
43dd59d 
Ref. #177
@Fil
Copy link
Member

Fil commented Aug 26, 2020

fixed in https://github.com/d3/d3-geo-projection/blob/ee1dd3f9b9db46cd7a1ed415694440ba9c411dc6/package.json (in two commits, ha!) for v3.0.0

@Fil Fil closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fil @mbostock